Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Forge builds to the multi-region Docker repository #12717

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Switch Forge builds to the multi-region Docker repository #12717

merged 3 commits into from
Mar 28, 2024

Conversation

sionescu
Copy link
Contributor

Description

Cherry-pick Forge and Docker build changes from main: push Docker images only to the newer multi-region repository.

How Has This Been Tested?

Already in main.

sionescu and others added 3 commits March 27, 2024 20:02
@sionescu
[Forge] Switch Forge to the multi-region Docker repository
3650369
@perryjrandall @sionescu
[docker] Check that version matches tag before publishing release images
4fe90ba 
We currently dont check that the tag and the aptos-node cargo.toml version match

This ensures that before publish we have to check the tag and version match only for release images

Test Plan: wrote unittests and added a testing workflow

made the script possibel to unittest
@sionescu
Stop pushing to the old GCP Docker repository
a94e8b5 
Reference GCP_DOCKER_ARTIFACT_REPO as configuration variable for
better debuggability.
@sionescu sionescu requested a review from perryjrandall March 28, 2024 00:04
@sionescu sionescu requested review from a team and JoshLind as code owners March 28, 2024 00:04
@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 28, 2024 •
edited
Loading

⏱️ 4h 49m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 15m 🟩 🟩 
windows-build 54m 🟩 🟩 
rust-smoke-tests 33m 🟩 
execution-performance / single-node-performance 20m 🟥 
rust-images / rust-all 19m 🟩 
rust-lints 18m 🟩 🟩 
forge-compat-test / forge 14m 🟩 
forge-e2e-test / forge 14m 🟩 
run-tests-main-branch 13m 🟥 🟥 
check 9m 🟩 🟩 
cli-e2e-tests / run-cli-tests 6m 🟩 
check-dynamic-deps 5m 🟩 🟩 
general-lints 5m 🟩 🟩 
semgrep/ci 54s 🟩 🟩 
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩 
file_change_determinator 27s 🟩 🟩 
file_change_determinator 25s 🟩 🟩 
test-copy-images 20s 🟩 
file_change_determinator 19s 🟩 
execution-performance / file_change_determinator 13s 🟩 
determine-docker-build-metadata 9s 🟩 
permission-check 7s 🟩 🟩 
permission-check 7s 🟩 🟩 
permission-check 6s 🟩 🟩 
permission-check 6s 🟩 🟩 
permission-check 4s 🟩 

🚨 5 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 6m 4m +53%
rust-unit-tests 38m 27m +44%
rust-lints 9m 7m +27%
windows-build 25m 20m +24%
rust-images / rust-all 19m 16m +21%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@sionescu sionescu enabled auto-merge (rebase) March 28, 2024 18:12
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> a94e8b5b7ac5182e44cf10fb92fbfa4978a4028c

Compatibility test results for aptos-node-v1.9.5 ==> a94e8b5b7ac5182e44cf10fb92fbfa4978a4028c (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6704 txn/s, latency: 4988 ms, (p50: 4800 ms, p90: 8900 ms, p99: 9800 ms), latency samples: 234640
2. Upgrading first Validator to new version: a94e8b5b7ac5182e44cf10fb92fbfa4978a4028c
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 749 txn/s, latency: 32796 ms, (p50: 34800 ms, p90: 52000 ms, p99: 53600 ms), latency samples: 58440
3. Upgrading rest of first batch to new version: a94e8b5b7ac5182e44cf10fb92fbfa4978a4028c
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 178 txn/s, submitted: 514 txn/s, expired: 335 txn/s, latency: 42186 ms, (p50: 36500 ms, p90: 55200 ms, p99: 64300 ms), latency samples: 13940
4. upgrading second batch to new version: a94e8b5b7ac5182e44cf10fb92fbfa4978a4028c
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2424 txn/s, latency: 12171 ms, (p50: 11500 ms, p90: 19200 ms, p99: 19500 ms), latency samples: 118780
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> a94e8b5b7ac5182e44cf10fb92fbfa4978a4028c passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a94e8b5b7ac5182e44cf10fb92fbfa4978a4028c

two traffics test: inner traffic : committed: 7019 txn/s, latency: 5577 ms, (p50: 5400 ms, p90: 6900 ms, p99: 12300 ms), latency samples: 3039380
two traffics test : committed: 100 txn/s, latency: 2100 ms, (p50: 2000 ms, p90: 2300 ms, p99: 8400 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.223, avg: 0.204", "QsPosToProposal: max: 0.231, avg: 0.202", "ConsensusProposalToOrdered: max: 0.576, avg: 0.521", "ConsensusOrderedToCommit: max: 0.405, avg: 0.388", "ConsensusProposalToCommit: max: 0.939, avg: 0.909"]
Max round gap was 1 [limit 4] at version 1465397. Max no progress secs was 7.335171 [limit 15] at version 1465397.
Test Ok

@sionescu sionescu disabled auto-merge March 28, 2024 19:34
@sionescu sionescu merged commit f892495 into aptos-release-v1.10 Mar 28, 2024
82 of 83 checks passed
@sionescu sionescu deleted the stelian/aptos-release-v1.10-docker-build branch March 28, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perryjrandall perryjrandall perryjrandall approved these changes

@JoshLind JoshLind Awaiting requested review from JoshLind JoshLind is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sionescu @perryjrandall